Fix key-loop in Tree.add to reuse existing children for literal segments after a matcher boundary

The key-loop unconditionally called self.parse() and overwrote result.children[key] for literal segments after the walk-down loop broke at a parameter. This destroyed pre-existing subtrees (with their method children and handlers) when a second route (e.g. POST) shared the same literal sub-segments after a parameter. Added a children.get(key) reuse check before parse(), mirroring the walk-down loop's child-reuse logic but extended past the boundary where parameters live in path_matchers, not children.
2026-07-24 12:54:07 +00:00
parent 9a314f9bd3
commit 1e1e031a56
3 changed files with 69 additions and 0 deletions
@@ -216,3 +216,37 @@ class AsgiTest(unittest.TestCase):
            r = await client.get("/restaurants/42/unknown")
            self.assertEqual(404, r.status_code)

+    @async_test
+    async def test_nested_param_routes_multiple_methods(self):
+        app = KayaApp()
+
+        @app.GET('/restaurants/${id}')
+        async def restaurant(ctx: HttpContext, id: str) -> None:
+            await ctx.send_str(200, f"restaurant:{id}")
+
+        @app.GET('/restaurants/${id}/menu')
+        async def menu_get(ctx: HttpContext, id: str) -> None:
+            await ctx.send_str(200, f"menu_get:{id}")
+
+        @app.POST('/restaurants/${id}/menu')
+        async def menu_post(ctx: HttpContext, id: str) -> None:
+            await ctx.send_str(200, f"menu_post:{id}")
+
+        transport = httpx.ASGITransport(app=app)
+
+        async with httpx.AsyncClient(transport=transport, base_url="http://127.0.0.1:80") as client:
+            r = await client.get("/restaurants/42")
+            self.assertEqual(200, r.status_code)
+            self.assertEqual("restaurant:42", r.text)
+
+            r = await client.get("/restaurants/42/menu")
+            self.assertEqual(200, r.status_code)
+            self.assertEqual("menu_get:42", r.text)
+
+            r = await client.post("/restaurants/42/menu")
+            self.assertEqual(200, r.status_code)
+            self.assertEqual("menu_post:42", r.text)
+
+            r = await client.put("/restaurants/42/menu")
+            self.assertEqual(404, r.status_code)
+